Hi Mike,

I'm using WinGrid version 9.2, bounded  on DataSet.

My first goal is make a performance tuning for InitializeRow funcion, can be that the right way ?

In my application, binding 30.000 rows with my current InitializeRow take about 8seconds, I tried to comment InitializeRow and it takes about 3 seconds.

can you help me to do that ? Probabily i make some big mistakes...

I already read your great  WinGrid Performance Guide, and make some change according with that.

Thanks a lot 

The Performance guide covers the majority of cases. But if you want to post your InitializeRow code here, I'll be happy to take a quick look at it and see if I notice any obvious problems.

Hi Mike,

this is my InitializeRow, I’m sorry  I know this method is very convoluted.. hope you can help me..

  Private Sub Grid_InitializeRow(ByVal sender As System.Object, ByVal e As Infragistics.Win.UltraWinGrid.InitializeRowEventArgs) Handles Grid.InitializeRow

        Try

            Grid.BeginUpdate()

            Grid.EventManager.AllEventsEnabled = False

            If [Global].MainLayout IsNot Nothing Then

                If [Global].MainLayout.IsGrigliaFontBold = False Then

                    If e.Row.GetCellValue("Gestita") = True Then

                        e.Row.Appearance.FontData.Bold = Infragistics.Win.DefaultableBoolean.False

                    Else

                        e.Row.Appearance.FontData.Bold = Infragistics.Win.DefaultableBoolean.True

                    End If

                Else

                    e.Row.Appearance.FontData.Bold = Infragistics.Win.DefaultableBoolean.True

                End If

            End If

            If [Global].Operatore.AbilitaLockFonie AndAlso e.Row.GetCellValue("Locked") Then

                e.Row.Cells("Progressivo").Appearance.Image = imgLocked

            Else

                e.Row.Cells("Progressivo").Appearance.Image = imgGrid(e.Row.GetCellValue("Tipo"))

            End If

            Try

                Dim in_registrazione As Boolean = 0

                If Not (Convert.IsDBNull(e.Row.GetCellValue("InRegistrazioneRX"))) Then

                    in_registrazione = e.Row.GetCellValue("InRegistrazioneRX")

                End If

                If Not (Convert.IsDBNull(e.Row.GetCellValue("InRegistrazioneTX"))) Then

                    in_registrazione = in_registrazione Or e.Row.GetCellValue("InRegistrazioneTX")

                End If

                If in_registrazione Then

                    e.Row.Cells("Progressivo").Appearance.Image = imgInRegistrazione       'MANUEL 31-07-2007

                End If    'MANUEL 31-07-2007

                'Manuel: si colora la linea con il colore dell'importanza, se attivato da configurazione client.

                If ([Global].Config.ColoraLineaComeImportanza = True) Then

                    If (e.Row.GetCellValue("Importanza") = 1) Then

                        e.Row.Appearance.BackColor = System.Drawing.Color.Yellow

                    ElseIf (e.Row.GetCellValue("Importanza") = 2) Then

                        e.Row.Appearance.BackColor = System.Drawing.Color.Red

                    Else

                        e.Row.Appearance.BackColor = System.Drawing.Color.Empty

                    End If

                End If

                Dim ChiamanteColumn As Infragistics.Win.UltraWinGrid.UltraGridColumn = e.Row.Band.Columns("Chiamante")

                Dim ChiamatoColumn As Infragistics.Win.UltraWinGrid.UltraGridColumn = e.Row.Band.Columns("Chiamato")

                Dim NominativoUtilizzatoreColumn As Infragistics.Win.UltraWinGrid.UltraGridColumn = e.Row.Band.Columns("NominativoUtilizzatore")

                Dim IntestatarioColumn As Infragistics.Win.UltraWinGrid.UltraGridColumn = e.Row.Band.Columns("Intestatario")

                If (e.Row.GetCellValue("Verso") IsNot Nothing) AndAlso (e.Row.GetCellValue("Verso") IsNot DBNull.Value) Then

                    If (e.Row.GetCellValue("Verso") = InterfacceOmniLogServer.enmVersi.verso_uscente) Then

                        If (e.Row.Cells("Chiamato").Appearance.Image Is Nothing) AndAlso (e.Row.GetCellValue("Chiamato") IsNot DBNull.Value) AndAlso (e.Row.GetCellText(ChiamatoColumn).Trim <> String.Empty) Then

                            e.Row.Cells("Chiamato").Appearance.Image = imgGrid(11)

                        End If

                    ElseIf (e.Row.GetCellValue("Verso") = InterfacceOmniLogServer.enmVersi.verso_entrante) Then

                        If (e.Row.Cells("Chiamante").Appearance.Image Is Nothing) AndAlso (e.Row.GetCellValue("Chiamante") IsNot DBNull.Value) AndAlso (e.Row.GetCellText(ChiamanteColumn).Trim <> String.Empty) Then

                            e.Row.Cells("Chiamante").Appearance.Image = imgGrid(11)

                        End If

                    End If

                    If (e.Row.Cells("NominativoUtilizzatore").Appearance.Image Is Nothing) AndAlso (e.Row.GetCellValue("NominativoUtilizzatore") IsNot DBNull.Value) AndAlso (e.Row.GetCellText(NominativoUtilizzatoreColumn).Trim <> String.Empty) Then

                        e.Row.Cells("NominativoUtilizzatore").Appearance.Image = imgGrid(11)

                    End If

                    If (e.Row.Cells("Intestatario").Appearance.Image Is Nothing) AndAlso (e.Row.GetCellValue("Intestatario") IsNot DBNull.Value) AndAlso (e.Row.GetCellText(IntestatarioColumn).Trim <> String.Empty) Then

                        e.Row.Cells("Intestatario").Appearance.Image = imgGrid(11)

                    End If

                End If

            Catch ex As Exception

                Logging.Logger.Error("InitializeRow", ex)

            End Try

            If (e.Row.GetCellValue("DurataRx") IsNot DBNull.Value) Then

                If e.Row.Cells.Exists("DurataRxFormattata") Then

                    e.Row.Cells("DurataRxFormattata").Value = TimeSpan.FromSeconds(e.Row.GetCellValue("DurataRx")).ToString

                End If

            End If

            If Not (e.Row.GetCellValue("CodiceColore") Is DBNull.Value) Then

                If e.Row.GetCellValue("CodiceColore") <> TRASPARENT_COLOR Then

                    If Config.UtilizzaColoriGestioneContatti Then

                        e.Row.Appearance.BackColor = System.Drawing.Color.FromArgb(e.Row.GetCellValue("CodiceColore"))

                    Else

                        e.Row.Cells("CodiceColore").Appearance.BackColor = System.Drawing.Color.FromArgb(e.Row.GetCellValue("CodiceColore"))

                    End If

                End If

            End If

            If f_RowAdded Then

                f_RowAdded = False

                e.Row.RefreshSortPosition()

            End If

        Catch ex As Exception

            e.Row.Refresh()

            e.Row.RefreshSortPosition()

            Logging.Logger.Error("InitializeRow", ex)

        Finally

            Grid.EventManager.AllEventsEnabled = True

            Grid.EndUpdate()

        End Try

    End Sub

Thanks Mike, I'll take my time to read your post and apply your suggestions then i'll let you know.

Hi,

• I would take out the Try...catch block here. Catching exceptions is a good idea, of course, but if your code is actually hitting any exceptions and they are getting caught, it will cause serious slow-downs in your application. You are much better off using 'if' statements to check for the existence of an unbound column or to check for null to make sure you do not get any exceptions than you are catching those exceptions. If your Catch block is ever getting hit, then that is probably causing the vast majority of the performance problems.
• I would probably remove the BeginUpdate and EndUpdate calls here. I don't think those will gain you anything inside of InitializeRow since it is probably firing during a paint, anyway, and it might actually slow things down by forcing extra paints.
• I would take out the call to e.Row.Refresh and e.Row.RefreshSortPosition here. If you need to force the grid to re-sort when a value changes, do it in AfterRowUpdate so it will only happen when something has changed instead of on every InitializeRow call.
• This is probably a minor thing, but you are making a lot of comparisons with GetCellValue. This is fine, but you are letting VB do the casting for you. For example: If e.Row.GetCellValue("Gestita") = True Then     If the cell value happens to be null or DBNull, this will cause an exception. Even if it's not, you may be better off getting the cell value into an object, checking the Type, and then using CType to convert the returned value into a boolean yourself before you compare it to True.
• You are setting a lot of properties directly on the appearance. This is probably not a performance problems, but it may be a memory problem. You could save memory by creating a set of Appearances you need and then re-using them as needed. This is covered in the WinGrid Performance Guide. Although... it may not be possible in your case if you are applying different appearance settings to the same cell based on different criteria.